Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18761#discussion_r130215731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -241,6 +241,7 @@ trait RuntimeReplaceable extends UnaryExpression with
Unevaluable {
override def nullable: Boolean = child.nullable
override def foldable: Boolean = child.foldable
override def dataType: DataType = child.dataType
+ override lazy val canonicalized: Expression = child.canonicalized
--- End diff --
Btw, those aliases are not children of `RuntimeReplaceable` which is an
`UnaryExpression`. So we can't trim the aliases out by simple transforming the
expressions in `CleanupAliases`.
If we want to replace the non-children aliases in `RuntimeReplaceable`, we
need to add more codes to `RuntimeReplaceable` and modify all expressions of
`RuntimeReplaceable`. It makes the interface ugly IMO.
Consider those aliases will be replaced soon and no harm of them, that's
why I choose to simply override `canonicalized`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
