Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18771#discussion_r130226083
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
    @@ -114,13 +114,13 @@ class CacheManager extends Logging {
       }
     
       /**
    -   * Un-cache all the cache entries that refer to the given plan.
    +   * Un-cache the cache entry that refers to the given plan.
        */
       def uncacheQuery(spark: SparkSession, plan: LogicalPlan, blocking: 
Boolean): Unit = writeLock {
         val it = cachedData.iterator()
         while (it.hasNext) {
           val cd = it.next()
    -      if (cd.plan.find(_.sameResult(plan)).isDefined) {
    +      if (plan.sameResult(cd.plan)) {
    --- End diff --
    
    This is by design. This is for avoiding to get the incorrect results. See 
the original PR: https://github.com/apache/spark/pull/17097


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to