Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18769#discussion_r130244241
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
 ---
    @@ -459,6 +459,19 @@ class InsertIntoHiveTableSuite extends QueryTest with 
TestHiveSingleton with Bef
           }
       }
     
    +  test("set hive.exec.max.dynamic.partitions lose effect") {
    +    val cnt = 1001
    +    val sourceTable = "sourceTable"
    +    val targetTable = "targetTable"
    +    (0 until cnt).map(i => (i, i)).toDF("c1", 
"c2").createOrReplaceTempView(sourceTable)
    +    sql(s"create table $targetTable(c1 int) PARTITIONED BY(c2 int)")
    --- End diff --
    
    nit: Usually we use upper case for SQL keywords like SELECT, CREATE TABLE, 
etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to