Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2595#discussion_r18297053
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DTStatsAggregator.scala
---
@@ -159,161 +166,15 @@ private[tree] abstract class DTStatsAggregator(
* This method modifies this aggregator in-place.
*/
def merge(other: DTStatsAggregator): DTStatsAggregator = {
- require(allStatsSize == other.allStatsSize,
+ require(statsSize == other.statsSize,
s"DTStatsAggregator.merge requires that both aggregators have the
same length stats vectors."
- + s" This aggregator is of length $allStatsSize, but the other is
${other.allStatsSize}.")
+ + s" This aggregator is of length $statsSize, but the other is
${other.statsSize}.")
var i = 0
// TODO: Test BLAS.axpy
- while (i < allStatsSize) {
+ while (i < statsSize) {
--- End diff --
`statsSize` -> `allStatsSize` (replace all in this function)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
