Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18805#discussion_r130769858
  
    --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
    @@ -216,3 +218,30 @@ private final class SnappyOutputStreamWrapper(os: 
SnappyOutputStream) extends Ou
         }
       }
     }
    +
    +/**
    + * :: DeveloperApi ::
    + * ZStandard implementation of [[org.apache.spark.io.CompressionCodec]].
    + *
    + * @note The wire protocol for this codec is not guaranteed to be 
compatible across versions
    + * of Spark. This is intended for use as an internal compression utility 
within a single Spark
    + * application.
    + */
    +@DeveloperApi
    +class ZStandardCompressionCodec(conf: SparkConf) extends CompressionCodec {
    +
    +  override def compressedOutputStream(s: OutputStream): OutputStream = {
    +    val level = 
conf.getSizeAsBytes("spark.io.compression.zstandard.level", "1").toInt
    +    val compressionBuffer = 
conf.getSizeAsBytes("spark.io.compression.lz4.blockSize", "32k").toInt
    --- End diff --
    
    - wondering if we should share this config value OR have a new one.
    - do you want to set the default to something higher like 1mb or 4mb ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to