Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18749
Yes, this isn't RTC. It isn't even RTC with 1-vote consensus, because you
rightly say that you could merge with no other votes if it were obviously not
required. But whatever. We can pick the process we want, and the name isn't
important. I agree with your take and I think that's already the current
process.
This change was clearly reviewed by several other people, so I don't see an
issue with merging. If the objection was, "you didn't literally write 'LGTM'"
then no I don't agree that this is important, and not a convention I've seen
observed consistently. Think about the implication: someone says "yeah this
looks good" and then you block for a day begging them to come back and write
'LGTM'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
