Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/18668#discussion_r131194926 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -50,6 +50,7 @@ private[hive] object SparkSQLCLIDriver extends Logging { private val prompt = "spark-sql" private val continuedPrompt = "".padTo(prompt.length, ' ') private var transport: TSocket = _ + private final val SPARK_HADOOP_PROP_PREFIX = "spark.hadoop." --- End diff -- `spark.hadoop.` was tribal knowledge and was a sneaky way to stick values into Hadoop `Configuration` object (which can later also pass on to `HiveConf`). What does `spark.hive.` do ? Have never seen such configs and would like to know. Keeping that aside, are you proposing to drop that prefix at L145 ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org