Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18749
Yep, I agree with 'almost always', and tiny changes might not require them.
I think that's what I said you said? "some cases". See also
https://github.com/apache/spark/pull/18749#issuecomment-319892145
But this alone disagrees with the idea that all changes need the string
"LGTM" typed.
I am not sure why this popped up, but I propose we continue with the same
process and conventions we always have. If anyone's unsure about whether an
important review is affirmative: please ask.
Can we put this to bed now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
