GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/18851
[SPARK-21644][SQL] LocalLimit.maxRows is defined incorrectly
## What changes were proposed in this pull request?
The definition of `maxRows` in `LocalLimit` operator was simply wrong. This
patch introduces a new `maxRowsPerPartition` method and uses that in pruning.
The patch also adds more documentation on why we need local limit vs global
limit.
Note that this previously has never been a bug because the way the code is
structured, but future use of the maxRows could lead to bugs.
## How was this patch tested?
Should be covered by existing test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-21644
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18851.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18851
----
commit 9911176d901a6bdfadec3ef68b28e6dd2c82be9e
Author: Reynold Xin <r...@databricks.com>
Date: 2017-08-05T01:19:26Z
[SPARK-21644][SQL] LocalLimit.maxRows is defined incorrectly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
