Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18854#discussion_r131532024
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -396,6 +396,8 @@ case class Or(left: Expression, right: Expression)
extends BinaryOperator with P
override def sqlOperator: String = "OR"
+ override def nullable: Boolean = left.nullable && right.nullable
--- End diff --
uh... I did not read the original JIRA.
For foldable expressions, we will eventually evaluate them in the
Optimizer. Maybe, here, we do not need to introduce the extra complexity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
