Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18852#discussion_r131534235
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with
SharedSQLContext {
val e2 =
intercept[AnalysisException](spark.conf.unset(SCHEMA_STRING_LENGTH_THRESHOLD.key))
assert(e2.message.contains("Cannot modify the value of a static
config"))
}
+
+ test("SPARK-21588 SQLContext.getConf(key, null) should return null") {
+ withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "1") {
+ assert("1" == spark.conf.get(SQLConf.SHUFFLE_PARTITIONS.key, null))
+ assert("1" == spark.conf.get(SQLConf.SHUFFLE_PARTITIONS.key,
"<undefined>"))
+ }
+
+ assert(spark.conf.getOption("spark.sql.nonexistent").isEmpty)
+ assert(null == spark.conf.get("spark.sql.nonexistent", null))
--- End diff --
That's good. But with current test, we don't actually test against the case
of NPE which is the main issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
