Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18866#discussion_r131649661
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -262,7 +262,12 @@ case class HashPartitioning(expressions:
Seq[Expression], numPartitions: Int)
* Returns an expression that will produce a valid partition ID(i.e.
non-negative and is less
* than numPartitions) based on hashing expressions.
*/
- def partitionIdExpression: Expression = Pmod(new
Murmur3Hash(expressions), Literal(numPartitions))
+ def partitionIdExpression(useHiveHash: Boolean = false): Expression =
+ if (useHiveHash) {
+ Pmod(new HiveHash(expressions), Literal(numPartitions))
--- End diff --
Ok. Let's add a comment for the parameter `useHiveHash`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
