Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131656840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -79,18 +79,6 @@ private[sql] class TypeCollection(private val types:
Seq[AbstractDataType])
private[sql] object TypeCollection {
/**
- * Types that can be ordered/compared. In the long run we should
probably make this a trait
- * that can be mixed into each data type, and perhaps create an
`AbstractDataType`.
- */
- // TODO: Should we consolidate this with RowOrdering.isOrderable?
--- End diff --
Nope, `RowOrdering.isOrderable` (which is used by
`TypeUtils.checkForOrderingExpr`) returns true on a strict superset of this
type collection as it works for complex types that need recursive checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
