Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18802#discussion_r131712995
--- Diff: dev/run-tests.py ---
@@ -121,7 +121,7 @@ def determine_modules_to_test(changed_modules):
if modules.root in modules_to_test:
return [modules.root]
return toposort_flatten(
- {m: set(m.dependencies).intersection(modules_to_test) for m in
modules_to_test}, sort=True)
+ dict((m, set(m.dependencies).intersection(modules_to_test)) for m
in modules_to_test))
--- End diff --
I see you added these changes to fix the tests, but they're unrelated to
the patches you're backporting.
They should, at the very least, be a separate PR, if they're really needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
