Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18888#discussion_r132070100
--- Diff: python/pyspark/ml/pipeline.py ---
@@ -204,13 +282,20 @@ def copy(self, extra=None):
@since("2.0.0")
def write(self):
"""Returns an MLWriter instance for this ML instance."""
- return JavaMLWriter(self)
+ allStagesAreJava = True
+ stages = self.stages
+ for stage in stages:
+ if not isinstance(stage, JavaMLWritable):
+ allStagesAreJava = False
+ if allStagesAreJava:
+ return JavaMLWriter(self)
--- End diff --
I find the similar logic twice, can you move it to a util function ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
