Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18648#discussion_r132150474
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -136,8 +136,15 @@ class SparkHadoopUtil extends Logging {
     
       def getSecretKeyFromUserCredentials(key: String): Array[Byte] = { null }
     
    -  def loginUserFromKeytab(principalName: String, keytabFilename: String) {
    -    UserGroupInformation.loginUserFromKeytab(principalName, keytabFilename)
    +  def loginUserFromKeytab(principalName: String, keytabFilename: String): 
Unit = {
    +    if (!new File(keytabFilename).exists()) {
    +      throw new SparkException(s"Keytab file: ${keytabFilename}" +
    +        " specified in spark.yarn.keytab does not exist")
    --- End diff --
    
    nit: To be general, let's not mention the config name `spark.yarn.keytab` 
here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to