Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18853
If we change this behaviour, I think we better modify code in
`findCommonTypeForBinaryComparison` of `TypeCoercion` instead of your pr:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L130
```
val findCommonTypeForBinaryComparison: (DataType, DataType) =>
Option[DataType] = {
...
case (l: StringType, r: AtomicType) if r != StringType => Some(r)
case (l: AtomicType, r: StringType) if (l != StringType) => Some(l)
...
}
```
As another option, we could cast `NumericType` to wider `DecimalType`?
Since this change could have some runtime overhead and behaviour change, I'm
not sure this is acceptable. cc @gatorsmile @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
