Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18905#discussion_r132901938
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
@@ -378,6 +408,18 @@ protected File initRecoveryDb(String dbName) {
}
}
}
+
+ // Find a local_dir which is writable, to avoid creating ldb in a
read-only disk.
+ if (_recoveryPath == null) {
+ for (String dir : localDirs) {
+ File f = new File(dir);
+ if (checkFileAvailable(f)) {
+ _recoveryPath = new Path(dir);
+ break;
+ }
+ }
+ }
+
if (_recoveryPath == null) {
--- End diff --
If `_recoveryPath` is still null I think we should throw an exception here,
since none of the disk is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
