Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18918#discussion_r132921051 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -522,6 +522,8 @@ object ColumnPruning extends Rule[LogicalPlan] { * so remove it. */ private def removeProjectBeforeFilter(plan: LogicalPlan): LogicalPlan = plan transform { + case p1 @ Project(_, _ @ Filter(condition, _ @ Project(_, _: LeafNode))) + if !condition.deterministic => p1 --- End diff -- I don't get it from your explanation. If I understand it correctly, when there is a `Project` which selects subset of output from the `LeafNode`, if we remove it by the below pattern, we will retrieve all fields. Is it your purpose?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org