Github user jmchung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18930#discussion_r132984129
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ---
    @@ -361,10 +361,18 @@ case class JsonTuple(children: Seq[Expression])
       // the fields to query are the remaining children
       @transient private lazy val fieldExpressions: Seq[Expression] = 
children.tail
     
    +  // a field name given with constant null will be replaced with this 
pseudo field name
    +  private val nullFieldName = "__NullFieldName"
    --- End diff --
    
    @HyukjinKwon @viirya  Yep, we've discarded the fake field name and use 
Option here. We made a slight revision to deal with the None in 
`foldableFieldNames` instead of creating a new function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to