Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18700#discussion_r132996396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1096,8 +1099,42 @@ class SessionCatalog(
* This performs reflection to decide what type of [[Expression]] to
return in the builder.
*/
protected def makeFunctionBuilder(name: String, functionClassName:
String): FunctionBuilder = {
- // TODO: at least support UDAFs here
- throw new UnsupportedOperationException("Use
sqlContext.udf.register(...) instead.")
+ makeFunctionBuilder(name, Utils.classForName(functionClassName))
+ }
+
+ /**
+ * Construct a [[FunctionBuilder]] based on the provided class that
represents a function.
+ */
+ private def makeFunctionBuilder(name: String, clazz: Class[_]):
FunctionBuilder = {
+ // When we instantiate ScalaUDAF class, we may throw exception if the
input
+ // expressions don't satisfy the UDAF, such as type mismatch, input
number
+ // mismatch, etc. Here we catch the exception and throw
AnalysisException instead.
+ (children: Seq[Expression]) => {
+ try {
+ val clsForUDAF =
+
Utils.classForName("org.apache.spark.sql.expressions.UserDefinedAggregateFunction")
--- End diff --
```Scala
/**
* The base class for implementing user-defined aggregate functions (UDAF).
*
* @since 1.5.0
*/
@InterfaceStability.Stable
abstract class UserDefinedAggregateFunction
```
This interface has been marked as stable. Can we still move it? or make a
trait in Catalyst?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
