GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/18943
[SPARK-21731][build] Upgrade scalastyle to 0.9.
This version fixes a few issues in the import order checker; it provides
better error messages, and detects more improper ordering (thus the need
to change a lot of files in this patch). The main fix is that it correctly
complains about the order of packages vs. classes.
As part of the above, I moved some "SparkSession" import in ML examples
inside the "$example on$" blocks; that didn't seem consistent across
different source files to start with, and avoids having to add more on/off
blocks
around specific imports.
The new scalastyle also seems to have a better header detector, so a few
license headers had to be updated to match the expected indentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark SPARK-21731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18943
----
commit d38e7dd4547eb907ecd8a8223c5b22222f3ab1ff
Author: Marcelo Vanzin <van...@cloudera.com>
Date: 2017-08-14T23:59:15Z
[SPARK-21731][build] Upgrade scalastyle to 0.9.
This version fixes a few issues in the import order checker; it provides
better error messages, and detects more improper ordering (thus the need
to change a lot of files in this patch). The main fix is that it correctly
complains about the order of packages vs. classes.
As part of the above, I moved some "SparkSession" import in ML examples
inside the "$example on$" blocks; that didn't seem consistent across
different source files, and avoids having to add more on/off blocks
around specific imports.
It seems to also have a better header detector, so a few license headers
had to be updated to match the expected indentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
