Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18946#discussion_r133118690
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -573,4 +578,47 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
spark.sql("SELECT 3 AS c, 4 AS d, SUM(b) FROM testData2 GROUP BY c,
d"),
Seq(Row(3, 4, 9)))
}
+
+ private def assertNoExceptions(c: Column): Unit = {
--- End diff --
Could you move it to line 566, just before `test("SPARK-21580 ints in
aggregation expressions are taken as group-by ordinal.")`? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
