Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18538
@mgaido91 I made another pass and left some comments, mainly about naming
and annotation. This looks in good shape now. I'd suggest to following the name
in sklearn, which should be easy to understand for both developers and users.
Thanks for this great contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
