Github user janewangfb commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18492#discussion_r133355548
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -291,6 +297,16 @@ private[spark] trait SparkListenerInterface {
       def onBlockUpdated(blockUpdated: SparkListenerBlockUpdated): Unit
     
       /**
    +   * Called when a speculative task is submitted
    +   */
    +  def onSpeculativeTaskSubmitted(speculativeTask: 
SparkListenerSpeculativeTaskSubmitted): Unit
    +
    +  /**
    +   * Called when an extra executor is needed
    +   */
    +  def onExtraExecutorNeeded(): Unit
    --- End diff --
    
    @cloud-fan after thoughts, yes, I think we can get rid of 
extraExecutorNeeded event and handle it in ExecutorAllocationManager.scala.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to