GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/18959
[SPARK-18394][SQL] Make an Attribute.toSeq output order consistent
## What changes were proposed in this pull request?
This pr sorted output attributes on their name and exprId in
`Attribute.toSeq` to make the order consistent. If the order is different,
spark possibly generates different code and then misses cache in
`CodeGenerator`, e.g., `GenerateColumnAccessor` generates code depending on an
input attribute order.
## How was this patch tested?
Added tests in `AttributeSetSuite` and manually checked if the cache worked
well in the given query of the JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/spark SPARK-18394
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18959.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18959
----
commit 3201f0a4a6ee9421dbe50e6e3195a73d35d3ef20
Author: Takeshi Yamamuro <yamam...@apache.org>
Date: 2017-08-16T02:49:17Z
Keep a deterministic output order in Attribute.toSeq
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
