Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18955#discussion_r133422587
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -474,6 +474,10 @@ case class CollapseCodegenStages(conf: SQLConf)
extends Rule[SparkPlan] {
}
private def supportCodegen(plan: SparkPlan): Boolean = plan match {
+ // Do not enable whole stage codegen for a single limit.
+ case limit: BaseLimitExec if !limit.child.isInstanceOf[CodegenSupport]
||
+ !limit.child.asInstanceOf[CodegenSupport].supportCodegen =>
--- End diff --
We can also override `LocalLimitExec.supportCodegen` and make that depend
on the `child.supportCodegen`. That seems more elegant that to special case it
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
