GitHub user neoremind opened a pull request:
https://github.com/apache/spark/pull/18965
[SPARK-21749][CORE] Add comments for MessageEncoder to explain the wire
format
## What changes were proposed in this pull request?
Spark RPC is built upon TCP tier and leverage netty framework. It would be
better to have some comments in RPC module especially to explain the RPC
message wire format since it is critical to understand what Message consists
(header + payload). So Javadoc comments can be added into MessageEncoder class.
## How was this patch tested?
Only comments added. Existing unit tests are all passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neoremind/spark add_comments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18965.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18965
----
commit a65bc214be8c05a3901193f9cc57d00fbbf506d5
Author: xu.zhang <xu.zh...@hulu.com>
Date: 2017-08-16T14:37:23Z
Add comments for MessageEncoder to explain the wire format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
