Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18959#discussion_r133532316
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruningSuite.scala 
---
    @@ -162,7 +162,8 @@ class PruningSuite extends HiveComparisonTest with 
BeforeAndAfter {
           }.head
     
           assert(actualOutputColumns === expectedOutputColumns, "Output 
columns mismatch")
    -      assert(actualScannedColumns === expectedScannedColumns, "Scanned 
columns mismatch")
    +      assert(actualScannedColumns.sorted === expectedScannedColumns.sorted,
    --- End diff --
    
    Could you add a comment to explain where we call `AttributeSet.toSeq`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to