Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15435#discussion_r133636149
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -882,21 +882,28 @@ class LogisticRegression @Since("1.2.0") (
val model = copyValues(new LogisticRegressionModel(uid,
coefficientMatrix, interceptVector,
numClasses, isMultinomial))
- // TODO: implement summary model for multinomial case
- val m = if (!isMultinomial) {
- val (summaryModel, probabilityColName) =
model.findSummaryModelAndProbabilityCol()
- val logRegSummary = new BinaryLogisticRegressionTrainingSummary(
+
+ val (summaryModel, probabilityColName, predictionColName) =
model.findSummaryModel()
+ val logRegSummary = if (!isMultinomial || (isMultinomial && numClasses
<= 2)) {
--- End diff --
Oh sorry! I didn't think about this case where a model is specified as
multinomial but has 2 classes. What you had before is better: ```numClasses
<=2``` (without using ```isMultinomial```). Feel free to question my
suggestions :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
