GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/18972
[SPARK-21720][SQL] Fix 64KB JVM bytecode limit problem with AND or OR
## What changes were proposed in this pull request?
This PR changes `AND` or `OR` code generation to place condition and then
expressions' generated code into separated methods if these size could be
large. When the method is newly generated, variables for isNull and value are
declared as an instance variable to pass these values (e.g. isNull1409 and
value1409) to the callers of the generated method.
This PR resolved two cases:
* large code size of left expression
* large code size of right expression
## How was this patch tested?
Added a new test case into `CodeGenerationSuite`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiszk/spark SPARK-21720
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18972
----
commit b915d417c558d8904fd64fae39f55fb976b495f0
Author: Kazuaki Ishizaki <[email protected]>
Date: 2017-08-17T17:28:54Z
Initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
