Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/15435#discussion_r133844018 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1324,90 +1350,136 @@ private[ml] class MultiClassSummarizer extends Serializable { } /** - * Abstraction for multinomial Logistic Regression Training results. - * Currently, the training summary ignores the training weights except - * for the objective trace. - */ -sealed trait LogisticRegressionTrainingSummary extends LogisticRegressionSummary { - - /** objective function (scaled loss + regularization) at each iteration. */ - def objectiveHistory: Array[Double] - - /** Number of training iterations until termination */ - def totalIterations: Int = objectiveHistory.length - -} - -/** - * Abstraction for Logistic Regression Results for a given model. + * Abstraction for logistic regression results for a given model. */ sealed trait LogisticRegressionSummary extends Serializable { /** * Dataframe output by the model's `transform` method. */ + @Since("2.3.0") --- End diff -- I confirmed: These annotations are inherited, so users may be confused about why some Since annotations have changed. E.g., BinaryLogisticRegressionSummary.featuresCol will change from 1.5.0 to 2.3.0. I'd just remove the ones in the trait.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org