Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r134067110
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -148,18 +149,28 @@ private[kinesis] class KinesisReceiver[T](
kinesisCheckpointer = new KinesisCheckpointer(receiver,
checkpointInterval, workerId)
val kinesisProvider = kinesisCreds.provider
- val kinesisClientLibConfiguration = new KinesisClientLibConfiguration(
+ var kinesisClientLibConfiguration = new KinesisClientLibConfiguration(
checkpointAppName,
streamName,
kinesisProvider,
dynamoDBCreds.map(_.provider).getOrElse(kinesisProvider),
cloudWatchCreds.map(_.provider).getOrElse(kinesisProvider),
workerId)
.withKinesisEndpoint(endpointUrl)
- .withInitialPositionInStream(initialPositionInStream)
+
.withInitialPositionInStream(initialPosition.initialPositionInStream)
.withTaskBackoffTimeMillis(500)
.withRegionName(regionName)
+ // Update the Kinesis client lib config with timestamp
+ // if InitialPositionInStream.AT_TIMESTAMP is passed
+ kinesisClientLibConfiguration =
+ if (initialPosition.initialPositionInStream ==
InitialPositionInStream.AT_TIMESTAMP) {
--- End diff --
Here's a more-stylish way of doing this in Scala:
```
initialPosition match {
case atTimestamp: AtTimestamp =>
baseClientLibConfiguration.withTimestampAtInitialPositionInStream(atTimestamp.timestamp)
case _ =>
baseClientLibConfiguration
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
