Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18982#discussion_r134075445 --- Diff: python/pyspark/ml/tests.py --- @@ -455,6 +455,14 @@ def test_logistic_regression_check_thresholds(self): LogisticRegression, threshold=0.42, thresholds=[0.5, 0.5] ) + def test_preserve_set_state(self): + model = Binarizer() + self.assertFalse(model.isSet("threshold")) + model._transfer_params_to_java() --- End diff -- Would it make sense to do an actual transform here instead of the two inner parts of the transform?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org