Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18968
[Moving such checks from `In.checkInputDataTypes ` to
`checkAnalysis`](https://github.com/dilipbiswal/spark/commit/185159e82572fd8c41f482bae54f791d2bf1b56a)
looks cleaner to me. What we are doing in `In.checkInputDataTypes` does not
belong to `checkInputDataTypes`.
If we want to capture the potential analysis errors introduced by the
optimizer rule `PullupCorrelatedPredicates `, we should override `resolved`
instead of doing all these checks in `checkInputDataTypes`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
