Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19003#discussion_r134129199
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
    @@ -763,6 +763,47 @@ class VersionsSuite extends SparkFunSuite with Logging 
{
           }
         }
     
    +    test(s"$version: read avro file containing decimal") {
    +      val url = 
Thread.currentThread().getContextClassLoader.getResource("avroDecimal")
    +      val location = new File(url.getFile)
    +
    +      val tableName = "tab1"
    +      val avroSchema =
    +        """{
    +          |  "name": "test_record",
    +          |  "type": "record",
    +          |  "fields": [ {
    +          |    "name": "f0",
    +          |    "type": [
    +          |      "null",
    +          |      {
    +          |        "precision": 38,
    +          |        "scale": 2,
    +          |        "type": "bytes",
    +          |        "logicalType": "decimal"
    +          |      }
    +          |    ]
    +          |  } ]
    +          |}
    +        """.stripMargin
    +      withTable(tableName) {
    +        versionSpark.sql(
    +          s"""
    +             |CREATE TABLE $tableName
    +             |ROW FORMAT SERDE 
'org.apache.hadoop.hive.serde2.avro.AvroSerDe'
    +             |WITH SERDEPROPERTIES ('respectSparkSchema' = 'true')
    +             |STORED AS
    +             |  INPUTFORMAT 
'org.apache.hadoop.hive.ql.io.avro.AvroContainerInputFormat'
    +             |  OUTPUTFORMAT 
'org.apache.hadoop.hive.ql.io.avro.AvroContainerOutputFormat'
    +             |LOCATION '$location'
    +             |TBLPROPERTIES ('avro.schema.literal' = '$avroSchema')
    --- End diff --
    
    For such an example that requires users setting `TBLPROPERTIES`, it sounds 
like we are unable to use the `CREATE TABLE USING` command. cc @cloud-fan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to