Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18958#discussion_r134232538
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -970,30 +458,14 @@ public final int appendStruct(boolean isNull) {
protected boolean anyNullsSet;
/**
- * True if this column's values are fixed. This means the column values
never change, even
- * across resets.
- */
- protected boolean isConstant;
-
- /**
- * Default size of each array length value. This grows as necessary.
- */
- protected static final int DEFAULT_ARRAY_LENGTH = 4;
-
- /**
- * Current write cursor (row index) when appending data.
- */
- protected int elementsAppended;
-
- /**
* If this is a nested type (array or struct), the column for the child
data.
*/
protected ColumnVector[] childColumns;
--- End diff --
yea, because mostly the child columns are of the same type of concrete
column vector type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
