Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18973#discussion_r134345519
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala ---
    @@ -728,7 +729,16 @@ class FakeDefaultSource extends FakeSource {
     
           override def getBatch(start: Option[Offset], end: Offset): DataFrame 
= {
             val startOffset = 
start.map(_.asInstanceOf[LongOffset].offset).getOrElse(-1L) + 1
    -        spark.range(startOffset, end.asInstanceOf[LongOffset].offset + 
1).toDF("a")
    +        val ds = new Dataset[java.lang.Long](
    --- End diff --
    
    You dont even need Range LogicalPlan. Since its for debugging, you can 
directly create a DF from local seq `startOffset to endOffset`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to