Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19015#discussion_r134385680
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
 ---
    @@ -22,19 +22,26 @@ import java.util.Locale
     
     import scala.reflect.{classTag, ClassTag}
     
    +import org.apache.spark.sql.{AnalysisException, SaveMode}
     import org.apache.spark.sql.catalyst.TableIdentifier
    +import org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute
     import org.apache.spark.sql.catalyst.catalog._
    +import org.apache.spark.sql.catalyst.dsl.expressions._
    +import org.apache.spark.sql.catalyst.dsl.plans
    +import org.apache.spark.sql.catalyst.dsl.plans.DslLogicalPlan
    +import org.apache.spark.sql.catalyst.expressions.JsonTuple
     import org.apache.spark.sql.catalyst.parser.ParseException
     import org.apache.spark.sql.catalyst.plans.PlanTest
    -import org.apache.spark.sql.catalyst.plans.logical.Project
    +import org.apache.spark.sql.catalyst.plans.logical.{Generate, LogicalPlan, 
Project, ScriptTransformation}
     import org.apache.spark.sql.execution.SparkSqlParser
     import org.apache.spark.sql.execution.datasources.CreateTable
     import org.apache.spark.sql.internal.{HiveSerDe, SQLConf}
    +import org.apache.spark.sql.test.SharedSQLContext
     import org.apache.spark.sql.types.{IntegerType, StringType, StructField, 
StructType}
     
     
     // TODO: merge this with DDLSuite (SPARK-14441)
    -class DDLCommandSuite extends PlanTest {
    +class DDLCommandSuite extends PlanTest with SharedSQLContext {
    --- End diff --
    
    shall we rename it to `DDLParserSuite`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to