Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18253
Agree that it still seems like there's too many moving parts here. I don't
see a whole lot of difference between `BusQueue` and `GroupOfListener` (which
is a weird name, btw). A queue can have a bunch of listeners and a
`LiveListenerBus` can have a bunch of queues. I don't see the need for anything
more complicated than that.
`WithListenerBus` is another thing I don't understand; aside from the
really weird name, it seems to be mostly the same thing as `ListenerBus`.
Also to reinforce a previous comment, your code has a ton of style issues.
It doesn't matter that checkstyle doesn't complain about them; you still have
to follow the code convention of the project or we'll be forever pointing out
style issues in your code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
