Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19022#discussion_r134807546
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala
---
@@ -210,4 +210,13 @@ class ExpressionSetSuite extends SparkFunSuite {
assert((initialSet - (aLower + 1)).size == 0)
}
+
+ test("add multiple elements to set") {
+ val initialSet = ExpressionSet(aUpper + 1 :: Nil)
+ val setToAddWithSameExpression = ExpressionSet(aUpper + 1 :: aUpper +
2 :: Nil)
+ val setToAdd = ExpressionSet(aUpper + 2 :: aUpper + 3 :: Nil)
--- End diff --
Not very sure what you want to test in the second one. Are you want to test
the behavior of adding a set of expressions that do not exist in the initial
set?
-> `ExpressionSet(aUpper + 3 :: aUpper + 4 :: Nil)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
