Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18581#discussion_r134813986
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/source/libsvm/LibSVMOptions.scala ---
@@ -41,11 +41,15 @@ private[libsvm] class LibSVMOptions(@transient private
val parameters: CaseInsen
case o => throw new IllegalArgumentException(s"Invalid value `$o` for
parameter " +
s"`$VECTOR_TYPE`. Expected types are `sparse` and `dense`.")
}
+
+ val lineSeparator: Option[String] = parameters.get(LINE_SEPARATOR)
+ lineSeparator.foreach(s => require(s.nonEmpty, s"'$LINE_SEPARATOR'
cannot be an empty string."))
}
private[libsvm] object LibSVMOptions {
val NUM_FEATURES = "numFeatures"
val VECTOR_TYPE = "vectorType"
val DENSE_VECTOR_TYPE = "dense"
val SPARSE_VECTOR_TYPE = "sparse"
+ val LINE_SEPARATOR = "lineSep"
--- End diff --
Please use the full name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
