Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18968#discussion_r134933318
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -1286,8 +1286,16 @@ class Analyzer(
               resolveSubQuery(s, plans)(ScalarSubquery(_, _, exprId))
             case e @ Exists(sub, _, exprId) if !sub.resolved =>
               resolveSubQuery(e, plans)(Exists(_, _, exprId))
    -        case In(value, Seq(l @ ListQuery(sub, _, exprId))) if 
value.resolved && !sub.resolved =>
    -          val expr = resolveSubQuery(l, plans)(ListQuery(_, _, exprId))
    +        case In(value, Seq(l @ ListQuery(sub, _, exprId, _))) if 
value.resolved && !sub.resolved =>
    --- End diff --
    
    @viirya If we modified to 
    ```
    case In(value, Seq(l @ ListQuery(sub, _, exprId, _))) if value.resolved && 
!l.resolved
    ```
    would we still require the following case statement ? The following case 
looks a little
    strange as we are in the resolveSubqueries routine and check for 
sub.resolved == true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to