Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19039#discussion_r135045968
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
    @@ -94,6 +94,22 @@ private[scheduler] class BlacklistTracker (
       val nodeToBlacklistedExecs = new HashMap[String, HashSet[String]]()
     
       /**
    +   * Blacklists permanently the nodes listed in 
spark.blacklist.alwaysBlacklistedNodes
    +   * The blacklist timeout is set to a large value, effectively never 
expiring.
    +   */
    +  private val permanentlyBlacklistedNodes: Seq[String] =
    +    conf.get("spark.blacklist.alwaysBlacklistedNodes", 
"").split(',').map(_.trim).filter(_ != "")
    +  if (permanentlyBlacklistedNodes.nonEmpty) {
    --- End diff --
    
    We should make this a private function and init the val `_nodeBlacklist` 
with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to