Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19029#discussion_r135186430
--- Diff: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala ---
@@ -438,6 +438,10 @@ private[ml] object SummaryBuilderImpl extends Logging {
while (i < len) {
realVariance(i) = (currM2n(i) + deltaMean(i) * deltaMean(i) *
weightSum(i) *
(totalWeightSum - weightSum(i)) / totalWeightSum) / denominator
+ // Because of numerical error, it is possible to get negative
real variance
+ if (realVariance(i) < 0.0) {
--- End diff --
Hmm.. `WeightedLeastSquares` use another way to compute variance `Var(X) =
E(X^2) - E(X)^2`. But it seems also possible to have this problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
