Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19050#discussion_r135283339 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -98,6 +99,11 @@ object RewritePredicateSubquery extends Rule[LogicalPlan] with PredicateHelper { val (newCond, inputPlan) = rewriteExistentialExpr(Seq(predicate), p) Project(p.output, Filter(newCond.get, inputPlan)) } + + rewrotePlan transform { + case j @ Join(left, right, _, _) if !j.duplicateResolved => + j.copy(right = DedupQueryAttributesInPlans.dedupRight(left, right)) --- End diff -- `duplicateResolved` in logical `Join` doesn't consider if LeftSemi/LeftAnti or not. But as LeftSemi/LeftAnti only do output from one side (`left.output` in `logical.Join`), should we revise `duplicateResolved` for `logical.Join`? Then we don't need to dedup here.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org