Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18966#discussion_r135332868 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -582,6 +582,15 @@ object SQLConf { .intConf .createWithDefault(2667) + val CODEGEN_MAX_LINES_PER_FUNCTION = buildConf("spark.sql.codegen.maxCodegenLinesPerFunction") + .internal() + .doc("The maximum lines of a single Java function generated by codegen. " + --- End diff -- My understanding is not correct. Explain it for expressions only? rename it to ``` spark.sql.codegen.expressions.maxCodegenLinesPerFunction ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org