Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19032#discussion_r135356694
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
@@ -170,7 +178,7 @@ protected void serviceInit(Configuration conf) throws
Exception {
List<TransportServerBootstrap> bootstraps = Lists.newArrayList();
boolean authEnabled = conf.getBoolean(SPARK_AUTHENTICATE_KEY,
DEFAULT_SPARK_AUTHENTICATE);
if (authEnabled) {
- createSecretManager();
+ createSecretManager(recoveryEnabled);
--- End diff --
I think at this point it would be cleaner to do:
```
secretManager = new ShuffleSecretManager();
if (recoveryEnabled) {
loadSecretsFromDb();
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
