Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19055#discussion_r135526544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -322,6 +322,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ // We can add LZO after Apache ORC 1.4.0 is used.
+ val ORC_COMPRESSION = buildConf("spark.sql.orc.compression.codec")
+ .doc("Sets the compression codec use when writing ORC files.
Acceptable values include: " +
+ "uncompressed, snappy, zlib.")
+ .stringConf
+ .transform(_.toLowerCase(Locale.ROOT))
+ .checkValues(Set("uncompressed", "snappy", "zlib"))
--- End diff --
Hm, but `lzo` still seeks `org.apache.hadoop.hive.ql.io.orc.LzoCodec`
though. Wouldn't it be better to leave as what it is intended for now if I
understood correctly? I think it should be almost seldom but disallowing `lzo`
actually looks disallowing the chance of a custom use allowed via `.option()`
API.
I think `none` was introduced as a compression key for `.option()` first
for Parquet and it was matched for consistency. I think we have kept `none` for
`.option()` API specific somehow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
