Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19062#discussion_r135893840
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -56,14 +56,11 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]
with Logging with Serializ
protected def sparkContext = sqlContext.sparkContext
- // sqlContext will be null when we are being deserialized on the slaves.
In this instance
- // the value of subexpressionEliminationEnabled will be set by the
deserializer after the
- // constructor has run.
- val subexpressionEliminationEnabled: Boolean = if (sqlContext != null) {
--- End diff --
cc @marmbrus @cloud-fan Does this sound OK after we mark it as `lazy`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
